Skip to content

[tune] update release tests to import from tune#57956

Merged
matthewdeng merged 2 commits intoray-project:masterfrom
matthewdeng:train-v2-tune-tests
Oct 22, 2025
Merged

[tune] update release tests to import from tune#57956
matthewdeng merged 2 commits intoray-project:masterfrom
matthewdeng:train-v2-tune-tests

Conversation

@matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Oct 21, 2025

Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release tests to import from ray.tune instead of ray.train. The changes involve modifying import statements and updating the report function calls in two files: tune_scale_up_down.py and test_tune_worker_fault_tolerance.py. The goal is to align the tests with the changes described in the linked issue.

import ray

from ray import train, tune
from ray import tune
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change removes train from the import statement. Ensure that train is not used anywhere else in this file, as this could lead to errors.

import ray
from ray import train
from ray.train import Checkpoint, RunConfig, FailureConfig, CheckpointConfig
from ray.tune import Checkpoint, RunConfig, FailureConfig, CheckpointConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change updates the import statement to import Checkpoint, RunConfig, FailureConfig, and CheckpointConfig from ray.tune instead of ray.train. Verify that this change aligns with the intended behavior and that these classes are correctly implemented and available in the current context.

@ray-gardener ray-gardener bot added tune Tune-related issues release-test release test labels Oct 21, 2025
Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
@matthewdeng matthewdeng requested a review from a team October 21, 2025 21:28
Copy link
Contributor

@JasonLi1909 JasonLi1909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the tests for cluster_tune_scale_up_down.aws and cluster_trune_scale_up_down.kuberay are still failing.

@matthewdeng matthewdeng enabled auto-merge (squash) October 21, 2025 23:56
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 21, 2025
@matthewdeng matthewdeng merged commit 8338444 into ray-project:master Oct 22, 2025
8 checks passed
elliot-barn pushed a commit that referenced this pull request Oct 23, 2025
## Description

Fix release tests that are still importing from `ray.train` to import
from `ray.tune`, as described in
#49454.

## Additional information

Test Runs:

| Test Name | Before | After|
| --- | --- | ---|
| `cluster_tune_scale_up_down.aws` |
https://buildkite.com/ray-project/release/builds/64733#019a0546-dbe2-47b1-ba85-983d48098352
|
https://buildkite.com/ray-project/release/builds/64809/steps/canvas?sid=019a0804-dc62-4177-a24a-b23806cd0d51
|
| `cluster_tune_scale_up_down.kuberay` |
https://buildkite.com/ray-project/release/builds/64733#019a0549-25dd-4dd3-ba84-df9d3ce5a72a
|
https://buildkite.com/ray-project/release/builds/64809/steps/canvas?sid=019a0804-dc63-49b3-8efc-ff3bd5fb8d28
|
| `tune_worker_fault_tolerance` |
https://buildkite.com/ray-project/release/builds/64734#019a058c-2f15-401c-88d9-894002152fff
|
https://buildkite.com/ray-project/release/builds/64845/steps/canvas?sid=019a08aa-6c85-43d4-83e0-bf56d49ab474
|

---------

Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests release-test release test tune Tune-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants